Bug #2509

Redefinition of DIRBLKSIZ in restore(8)

Added by swildner almost 2 years ago.

Status:NewStart date:02/07/2013
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

I noticed that sbin/restore/interactive.c includes both <dirent.h> and <vfs/ufs/dir.h>, both of which define DIRBLKSIZ, but to different values.

In <dirent.h>:

#define DIRBLKSIZ 1024

In <vfs/ufs/dir.h>:

#define DIRBLKSIZ DEV_BSIZE

It seems to be a poor choice of names and ends up being 512 just by the ordering of includes in interactive.c.

Venkatesh told me to file a bug (so he doesn't forget), which I hereby did.

Also available in: Atom PDF