Project

General

Profile

Submit #2778

[PATCH 0/3] lib/libhammer: fix minor memory leaks and cleanups

Added by tkusumi over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Userland
Target version:
Start date:
01/25/2015
Due date:
% Done:

0%


Description

These series of patches for libhammer do the followings.

---
From: Tomohiro Kusumi <>
Date: Sun, 25 Jan 2015 22:38:50 +0900
Subject: [PATCH 1/3] lib/libhammer: fix minor memory leaks

This patch fixes minor memory leaks of libhammer.

hunk1: This isn't necessary since it never gets here.
_libhammer_malloc() exit(1) if it failed to calloc().
hunk2: Add missing close(fd).
hunk3: Add missing free(mntbuf).

---
From: Tomohiro Kusumi <>
Date: Sun, 25 Jan 2015 22:41:59 +0900
Subject: [PATCH 2/3] lib/libhammer: cleanups

This patch has some minor cleanups of libhammer.

hunk1: Remove parentheses
hunk2: Remove parentheses
hunk3: Remove forward declaration of obsolete function.
find_pfs_mount() was re-implemented as a part of libhammer
and commit 4f09feab replaces it with libhammer version.

---
From: Tomohiro Kusumi <>
Date: Sun, 25 Jan 2015 23:13:04 +0900
Subject: [PATCH 3/3] lib/libhammer: cleanups

Using pointer dereference instead of several mntbuf[curmount].f_xxx
makes code clear and also makes lines fit within 80 characters.

0001-lib-libhammer-fix-minor-memory-leaks.patch View (1.36 KB) tkusumi, 01/25/2015 06:59 AM

0002-lib-libhammer-cleanups.patch View (1.71 KB) tkusumi, 01/25/2015 06:59 AM

0003-lib-libhammer-cleanups.patch View (1.9 KB) tkusumi, 01/25/2015 06:59 AM

History

#1 Updated by tuxillo about 2 years ago

  • Status changed from New to Closed
  • Assignee set to tuxillo
  • Target version set to 4.2.x

Hi,

All pushed to master. Thanks!

Cheers,
Antonio Huete

Also available in: Atom PDF