Project

General

Profile

Submit #2864

boot0 refactoring

Added by Anonymous almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
12/10/2015
Due date:
% Done:

0%


Description

Hello,

this patch provides little refactoring for the sys/boot/pc32/boot0 to improve
readability and comprehensibility of assembly code.

The main changes are:

Two new symbols added: _SECTOR_FIELD_OFF which provides offset for the 'sector'
field in CHS and _DATA_OFF which provides offset for the boot0 data from the
partition table.

Some comments are improved

The patch was tested as in virtual machine as in real hardware (laptop ASUS M50).

Thank you.

0001-some-refactoring-for-boot0.patch View (4.18 KB) Anonymous, 12/12/2015 10:36 AM

History

#1 Updated by Anonymous almost 2 years ago

  • Tracker changed from Bug to Submit

#2 Updated by Anonymous almost 2 years ago

  • Status changed from New to In Progress

#3 Updated by Anonymous almost 2 years ago

  • File deleted (0001-some-refactoring-for-boot0.patch)

#4 Updated by Anonymous almost 2 years ago

I've updated patch and waiting for feedback. The main change is - improved some comments.

#5 Updated by dillon almost 2 years ago

  • Assignee set to dillon

Looks pretty good. If you are done working on it I will commit it.

-Matt

#6 Updated by Anonymous almost 2 years ago

dillon wrote:
> Looks pretty good. If you are done working on it I will commit it.
>
> -Matt

Hello @dillon,

Yes, I've finished with it.

Thank you.

#7 Updated by swildner almost 2 years ago

  • Status changed from Feedback to Closed

I've pushed it. Thanks.

Also available in: Atom PDF