Project

General

Profile

Bug #2928

Patch from later Linux drm: drm/fb-helper: Use proper plane mask for fb cleanup

Added by davshao almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
07/22/2016
Due date:
% Done:

0%

Estimated time:

Description

Thanks for the update to Linux 4.4 drm. There is a subtle bug
in the usage of drm_plane_index() in function pan_display_atomic()
of drm_fb_helper.c, found by Matt Roper. For reference:

https://patchwork.kernel.org/patch/7889051/

Please apply the following patch:

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index 69cbab5..1e103c4 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1251,7 +1251,7 @@ retry:
goto fail;

plane = mode_set->crtc->primary;
- plane_mask |= drm_plane_index(plane);
+ plane_mask |= (1 << drm_plane_index(plane));
plane->old_fb = plane->fb;
}

History

#1 Updated by dillon almost 2 years ago

  • Status changed from New to Closed

Thanks for the heads-up, the fix has been committed!

-Matt

Also available in: Atom PDF