Bug #321

SYSCTL_XXX still wants dev_t, not cdev_t

Added by frank about 8 years ago. Updated about 8 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

With the recent renaming of the kernel's dev_t to cdev_t the dev_t type
sysctl variables, namely, "kern.dumpdev" and "machdep.consdev", have
disappeared (at least these two are affected). Please consider the below
modifications to bring them back again.

Regards,
Frank Josellis

--- patch begins here ---
--- src/sys/kern/kern_shutdown.c.orig 2006-09-10 03:26:39.000000000 +0200
+++ src/sys/kern/kern_shutdown.c 2006-09-21 13:39:31.000000000 +0200
@@ -521,7 +521,7 @@
}

SYSCTL_PROC(_kern, KERN_DUMPDEV, dumpdev, CTLTYPE_OPAQUE|CTLFLAG_RW,
- 0, sizeof dumpdev, sysctl_kern_dumpdev, "T,cdev_t", "");
+ 0, sizeof dumpdev, sysctl_kern_dumpdev, "T,dev_t", "");

/*
* Doadump comes here after turning off memory management and
---pach ends here ---

--- patch begins here ---
--- src/sys/kern/tty_cons.c.orig 2006-09-10 03:26:39.000000000 +0200
+++ src/sys/kern/tty_cons.c 2006-09-21 13:39:31.000000000 +0200
@@ -91,7 +91,7 @@
static cdev_t cn_dev;
static udev_t cn_udev;
SYSCTL_OPAQUE(_machdep, CPU_CONSDEV, consdev, CTLFLAG_RD,
- &cn_udev, sizeof cn_udev, "T,cdev_t", "");
+ &cn_udev, sizeof cn_udev, "T,dev_t", "");

static int cn_mute;

--- patch ends here ---

History

#1 Updated by dillon about 8 years ago

:With the recent renaming of the kernel's dev_t to cdev_t the dev_t type
:sysctl variables, namely, "kern.dumpdev" and "machdep.consdev", have
:disappeared (at least these two are affected). Please consider the below
:modifications to bring them back again.
:
:Regards,
:Frank Josellis

That's definitely a bug, but I think I am going to rename them to
udev_t instead of dev_t and I'll adjust the sysctl code to recognize
'udev_t' as well as 'dev_t'.

-Matt

Also available in: Atom PDF