Bug #664

Second patch for CARP

Added by baptiste.ritter over 7 years ago. Updated about 7 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Hi all,

Here is an update of the patch, sent by Jonathan Buschmann on the kernel
mailing list (at the 14 march).

Differences between this patch and the first-one submitted on the kernel
mailing list :
- The announced IPv6 bug corrected (CARP interface which did not reply
to Neighbor Sollicitation)
- Some man pages was imported/updated
- LINT config file updated
- Code updated for "syncing" with CVS.
- Suppression of the code for "Report link states changes" witch was
in "conflict")
- The patch was generated (and tested) with the RSYNC/Devel snapshot
from May 20. (We had some difficulties with accessing the CVS
server for keeping our sources up to date. :-( )
- Code cleanup (nuke some commented-out code)

Notes :
- As Sacha Wildner suggest to Jonathan, we should add IFM_CARP to
ifmedia(4) man page. But, on reading other BSD man pages, they didn't
do that ; Should it be or not, and what add ? (According to the fact
that IFM_CARP is a "virtual" media")
- English is not our native language and the man page of PFSYNC from
DragonflyBSD is not the same than others BSD. So I added a paragraph
with CARP (imported from FreeBSD man page) ; It is just an example "in
the middle of nowhere in the man page" ; I find that a little bit
strange, may be there is a better choice...
- A lot of other things (I don't remember what...)

Regards,

carp-20070529BR01.patch Magnifier (105 KB) baptiste.ritter, 05/29/2007 08:24 PM

carp-20070811BR01.patch Magnifier (105 KB) baptiste.ritter, 08/11/2007 07:38 PM

History

#1 Updated by swildner over 7 years ago

Never mind IFM_CARP. At the time I suggested this to Jonathan, I didn't
check NetBSD (which, as you noted, didn't put this in their ifmedia(4)).

Don't worry. Looks fine and we can sort the details out afterwards.
Let's see what Scott finds in testing the patch.

Sascha

#2 Updated by bastyaelvtars over 7 years ago

On Tue, 29 May 2007 22:14:49 +0200
Baptiste Ritter <> wrote:

Hi,

yesterday I said that the patch applies cleanly. This is not true, I
get:

patch: **** malformed patch at line 931: @@ -801,8 +821,10 @@
in_arpinput(struct mbuf *m)

and it stops.

#3 Updated by baptiste.ritter over 7 years ago

I just tried the patch on the two following tarballs:
- src-Release-1.10.tar.bz2 66315 KB 06.08.2007 13:11:00
- src-Devel.tar.bz2 66990 KB 08.08.2007 01:10:00

The both operation terminated with success.

May be, your patch files is damaged ; you should directly wget the file
from http://bugs.dragonflybsd.org/file261/carp-20070529BR01.patch

For information, the version of my patch software is 2.0-12u8-OpenBSD
and my md5sum of the "wgeted" file is fa0361adf7c2a34a92f7637278e44b3f

Regards,

#4 Updated by bastyaelvtars over 7 years ago

On Wed, 08 Aug 2007 21:43:28 +0200
Baptiste Ritter <> wrote:

I was thinking the same and tried 3 different ways but looks like the
attachment got corrupted somehow, because even extracting from the mail
archive site's code failed, not to talk of FTP, Samba and other
protocols.

Either way, this works. Thank you, and I'll insult you next week if I
have errors. I did RTFM, so I know what I should do.

Se you soon,

#5 Updated by thomas.nikolajsen over 7 years ago

Please update carp(4) SYNOPSIS to:
options CARP
pseudo-device carp
(not 'device carp').

-thomas

#6 Updated by baptiste.ritter over 7 years ago

Done ; the new patch is attached.

Thanks Thomas for keeping a close watch to the patch.

Cheers,

#7 Updated by dillon over 7 years ago

It looks to me like this is ready enough to be committed to widen the
testing arena. Mr Ritter, do you think its good enough to go into the
tree? We can always apply more patches as they come in.

I'm sorry I can't test it myself, I'm overloaded with work at the moment.

-Matt

#8 Updated by baptiste.ritter over 7 years ago

For me (and my colleagues Jonathan and Nicolas) the patch is good enough to be committed ;
Furthermore, we think that by committing the patch we should have more feedbacks.

And if there is a bug discovered, we are here for assuring the support and correct it.

Regards,

#9 Updated by thomas.nikolajsen over 7 years ago

I have done some CARP testing; it worked as expected.

Test was using 3 pc's on LAN (2 CARP enabled & one observer (ping))
(I guess vkernels sould be just as good :).

Regarding carp(4) SYNOPSIS: I think this should include 'options CARP'.
This is used in VKERNEL & LINT
(my initial problem was that kernel didn't link w/o this).

It would be nice to have CARP GENERIC;
this not done in patch, but it is included in VKERNEL.

Thanks for porting this nice feature.

-thomas

#10 Updated by bastyaelvtars over 7 years ago

On Wed, 15 Aug 2007 20:32:41 -0000
Thomas Nikolajsen <> wrote:

That's my fault: I have patched with the older diff. The new one has
this fixed.

#11 Updated by dillon over 7 years ago

:For me (and my colleagues Jonathan and Nicolas) the patch is good enough to be committed ;
:Furthermore, we think that by committing the patch we should have more feedbacks.
:
:And if there is a bug discovered, we are here for assuring the support and correct it.
:
:Regards,
:
:--
:Baptiste Ritter

I've got it all ready to commit. I need to what attribution to put in
the commit message though.

Submitted-by: Baptiste Ritter <>,
Jonathan ?
Nicolas ?

Reviewed-by: Thomas Nikolajsen
Gergo Szakal <>

Obtained-from: OpenBSD, NetBSD, and FreeBSD

You can give me as little or as much information as you want on
your collegues.

-Matt
Matthew Dillon
<>

#12 Updated by thomas.nikolajsen over 7 years ago

SYSOPSIS isn't including 'options CARP' in new patch in this issue.
Change between the two patches in this issue is just:
s/device carp/pseudo-device carp/

-thomas

http://bugs.dragonflybsd.org/file329/carp-20070811BR01.patch
..
+.Sh SYNOPSIS
+.Cd "pseudo-device carp"
+.Sh DESCRIPTION
..

#13 Updated by dillon over 7 years ago

:It would be nice to have CARP GENERIC;
:this not done in patch, but it is included in VKERNEL.
:
:Thanks for porting this nice feature.
:
: -thomas

I'm going to hold off making it the default in GENERIC and VKERNEL
until we can think that through a bit more.

Actually, you know what we *REALLY* need, we need a 'kernel' manual
page which describes all the really cool options kernels can be built
with in detail. LINT doesn't really do it justice.

-Matt
Matthew Dillon
<>

#14 Updated by TGEN over 7 years ago

Like options(4) on NetBSD?

Cheers,
--
Thomas E. Spanjaard

#15 Updated by bastyaelvtars over 7 years ago

On Wed, 15 Aug 2007 14:26:48 -0700 (PDT)
Matthew Dillon <> wrote:

My role was testing. I cannot review this :-)

#16 Updated by dillon over 7 years ago

Patch #2 has been committed! I do not have it set as the default
for any kernels yet, though.

-Matt

#17 Updated by baptiste.ritter over 7 years ago

Although I've seen that it is already commit, for information my colleagues were:
- Jonathan Buschmann <>
- Nicolas Riss <>

Cheers,

Also available in: Atom PDF