short _file in stdio -> fd leak
So at work we ran into a situation where a process had to fdopen more
than 32K files, which lead to a file descriptor leak. The reason for
this leak was that while regular fds are ints, _file is a short, so if
fdopen got an fd larger than SHRT_MAX, it would get sign-extended and
thus become invalid, causing the subsequent fclose to fail.
This being FreeBSD, the fix was found and contributed back into
FreeBSD's repository by John Baldwin in
(and other files; with surrounding discussion on
This fix was also added in NetBSD in
I don't know if this also affects DragonFlyBSD but maybe it should
probably be looked at.