Actions
Bug #2278
closed"Password hashing weakness in DF" (Matthias Schmidt)
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:
0%
Estimated time:
Description
Further to the email posted by Matthias Schmidt to DragonFly users list
(17/01/2012):
I had a look at (GitWeb) the source code:
lib/libcrypt/crypt-sha256.c
and
lib/libcrypt/crypt-sha512.c
Both of those C files have bugs in them: "crypt-sha256.c:":
....
/* Then the magic string */
SHA256_Update(&ctx, magic, sizeof(magic));
....
Should be strlen(magic) instead of sizeof(magic).
-----
And practically the same bug in: "crypt-sha512.c":
....
/* Then the magic string */
SHA512_Update(&ctx, magic, sizeof(magic));
.....
Should be strlen(magic) instead of sizeof(magic).
------
There might be other bugs - I didn't really check for any .....
--
Sincerely,
Robin Carey BSc
Actions