Bug #2480
closed
/usr/bin/dialog buffer size too small
0%
Description
Running "make config" in /usr/dports/print/ghostscript9 crashes the dialog program.
Increasing the MAX_LEN value in /usr/src/gnu/lib/libdialog/dialog.h:78 from 2k to 20k "fixes" this issue.
The output size (using the default options in the above example) is about 3.7k.
Updated by memmerto over 11 years ago
As far as I can tell, this should cause similar problems on FreeBSD whose dialog also has MAX_LEN 2048.
Suggest two changes:
- work with upstream maintainer to increase MAX_LEN (4k is sufficient, but a higher limit may be useful)
- merge up to FreeBSD r224014 which is upstream 1.1-20110707
Updated by isenmann over 11 years ago
Hmm wonder, why I haven't seen this on FreeBSD-9.1?
Looks like there are two different versions:
/usr/src/gnu/lib/libodialog/dialog.h:#define MAX_LEN 4096
/usr/src/contrib/dialog/dialog.h:#define MAX_LEN 2048
The output of "/usr/bin/dialog --help" starts with:
cdialog (ComeOn Dialog!) version 1.1-20100428
Copyright 2000-2008,2011 Thomas E. Dickey
That seems to be the version from contrib, and AFAIKS this
versions has no problem with 3.7k output.
Updated by memmerto over 11 years ago
Looks like we don't need an upstream fix, but rather just an update to a new version.
Updated by marino over 11 years ago
- Assignee set to dragonflybsd1
Correct, our dialog is ancient.
I saw the ghostscript crash as well.
Updating libdialog was on my mid-term to-do list, but it's nice to have a bug tracking this.
I'll take the ticket.
Updated by marino about 11 years ago
While waiting for new libdialog, MAX_LEN has been increased on old one:
http://gitweb.dragonflybsd.org/dragonfly.git/tree/c090922fe69732915227914768a9c4f9190fdece
Updated by marino about 11 years ago
- Status changed from New to Closed
pavalos has completed the libdialog upgrade. Thanks Peter!