Project

General

Profile

Actions
Copy link

Submit #2864

closed

boot0 refactoring

Added by Anonymous over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
dillon
Category:
-
Target version:
Unverifiable
Start date:
12/10/2015
Due date:
% Done:

0%

Estimated time:

Description

Hello,

this patch provides little refactoring for the sys/boot/pc32/boot0 to improve
readability and comprehensibility of assembly code.

The main changes are:

Two new symbols added: _SECTOR_FIELD_OFF which provides offset for the 'sector'
field in CHS and _DATA_OFF which provides offset for the boot0 data from the
partition table.

Some comments are improved

The patch was tested as in virtual machine as in real hardware (laptop ASUS M50).

Thank you.

Files

0001-some-refactoring-for-boot0.patch (4.18 KB) 0001-some-refactoring-for-boot0.patch Anonymous, 12/12/2015 10:36 AM
Actions
Copy link
 #1

Updated by Anonymous over 8 years ago

  • Tracker changed from Bug to Submit
Actions
Copy link
 #2

Updated by Anonymous over 8 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Anonymous over 8 years ago

  • File deleted (0001-some-refactoring-for-boot0.patch)
Actions
Copy link
 #4

Updated by Anonymous over 8 years ago

I've updated patch and waiting for feedback. The main change is - improved some comments.

Actions
Copy link
 #5

Updated by dillon over 8 years ago

  • Assignee set to dillon

Looks pretty good. If you are done working on it I will commit it.

-Matt

Actions
Copy link
 #6

Updated by Anonymous over 8 years ago

dillon wrote:

Looks pretty good. If you are done working on it I will commit it.

-Matt

Hello @dillon,

Yes, I've finished with it.

Thank you.

Actions
Copy link
 #7

Updated by swildner over 8 years ago

  • Status changed from Feedback to Closed

I've pushed it. Thanks.

Actions
Copy link

Also available in: Atom PDF