Project

General

Profile

Actions
Copy link

Bug #3010

closed

lib/libstand& lib/libtelnet: 3 problems

Added by dcb over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
04/04/2017
Due date:
% Done:

0%

Estimated time:

Description

1:

dragonfly/lib/libstand/hammer1.c:932]: (error) printf format string requires 3 parameters but only 2 are given.

Source code is

printf("hammer_open %s %p %ld\n", path, f);

2.

[dragonfly/lib/libtelnet/rsaencpwd.c:336]: (warning) Ineffective statement similar to '*A++;'. Did you intend to write '(*A)++;'?

3.

[dragonfly/lib/libtelnet/rsaencpwd.c:344]: (warning) Ineffective statement similar to '*A++;'. Did you intend to write '(*A)++;'?

Source code is

*ptr++;
Actions
Copy link
 #1

Updated by dillon over 7 years ago

  • Status changed from New to Closed

Clean up the code. None of these created any actual bug in the world build, but the code constructions were wrong. hammer1 is not used in libstand. And the ptr++ in rsaencpwd.c was supposed to be ptr++, so the original code actually worked even if it had the extra '' prefix.

Fix committed by Matt

Actions
Copy link

Also available in: Atom PDF