Actions
Bug #3079
closed
usr.bin/bc/tty.c: 2 * Suspicious condition
Status:
Closed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
10/11/2017
Due date:
% Done:
0%
Estimated time:
Description
usr.bin/bc/tty.c:34]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
while ((ret = tcsetattr(0, TCSADRAIN, t) -1) && errno EINTR)Maybe better code
while (((ret = tcsetattr(0, TCSADRAIN, t)) -1) && errno EINTR)dragonfly/usr.bin/bc/tty.c:44]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
while ((ret = tcgetattr(0, t) -1) && errno EINTR)
Updated by dillon about 7 years ago
- Status changed from New to Closed
Code actually works either way but syntax is clearly incorrect. Corrected syntax and committed into master.
-Matt
Actions