Project

General

Profile

Bug #3179

KKASSERT(bp->b_flags & B_VMIO);

Added by tkusumi about 2 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
02/28/2019
Due date:
% Done:

0%

Estimated time:

Description

This call
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/master/sys/kern/vfs_bio.c#L1526

looks to be incorrect given
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/master/sys/kern/vfs_bio.c#L3050

Not really sure how this "else" case happen though, as filesystem buffers are all B_VMIO (if not IO_VMIO).

History

#1

Updated by dillon about 2 years ago

The buffer cache used to have B_MALLOC buffers, but I recently removed those so it should now generally only be able to have B_VMIO buffers. There are specialized buffers that are not B_VMIO, but they are not attached to vnodes and do not use the brelse() mechanism.

I'm not sure if I want to remove that else clause yet (line 1520-1531), but it does warrant clarification in the code comment so I will adjust the comment for now.

-Matt

#2

Updated by tkusumi about 2 years ago

  • Status changed from New to Resolved

Also available in: Atom PDF