Project

General

Profile

Actions

Submit #3262

closed

[PATCH] talk: talk into account sa_len field in sockaddr.

Added by dancrossnyc 11 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Userland
Target version:
Start date:
01/14/2021
Due date:
% Done:

0%

Estimated time:

Description

`osockaddr` predates the introduction of the sa_len
field in `struct sockaddr`. The family has moved to
the second field in the structure, but `talk` didn't
account for this when it constructs a `sockaddr_in`
to send data to another system.

The failure case was kind of odd: one could `talk`
to a user on, say, a Linux machine, the remote user
could respond, and things would work as expected.
However, the inverse case, where a user on Linux
tried to `talk` to a user on Dragonfly failed: the
talk announcement would be made, but an attempt to
respond would fail with a protocol error since the
`sin_family` field would be zero.


Files

Actions #1

Updated by dancrossnyc 11 months ago

  • Tracker changed from Bug to Submit
Actions #2

Updated by dillon 11 months ago

  • Status changed from New to Resolved
  • Assignee set to dillon

Committed 1f28d7d499446ade

Actions

Also available in: Atom PDF