Project

General

Profile

Actions

Bug #647

closed

rough-draft VKERNEL host-initiated shutdown patch

Added by c.turner over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Disclaimer: MESSY!

Took a quick attempt at getting the VKERNEL to shutdown cleanly against
1.8,
and it seems to work just fine as suggested with mailbox signals, etc.

Attached is my 'cumulative' 1.8 vkernel patch against 1.8_Release
/usr/src/sys/platform/vkernel including the previous multi-vk changes.

Of course I will clean up and resubmit against Preview/Head, (along with
a patch for vkernel(7), but I wanted to have the general approach
validated before going too much further.

(plus I don't have a -HEAD / Preview machine set up at the moment,
but am working on it)

status:
- OK for simple shutdown case with init already fork()'ed.
- VK is too fast for me to catch the 'no init yet' shutdown case..
- need to merge against Preview, as things have changed there,
and re-submit. patch here includes previous multivkd work.

changes in:
- platform/vkernel/include/globaldata.h : maibox slot
- platform/vkernel/include/md_var.h : vk_shutdown prototype
- platform/vkernel/platform/kqueue.c : mailbox hook
- platform/vkernel/platform/init.c : vk_shutdown function

questions/notes:
- I didn't think I really needed a separate sigaction in
kqueue_setup..
- should shutdown mailbox handler dispatch happen higher up
(e.g. in platform/vkernel/i386/trap.c)
- should this actually follow
'vke_intr(void *xsc, struct intrframe *frame __unused)' conventions?
- we're not really checking for FD related IO kevents() ..
- this implies a more 'full device' kind of thing , with a struct,
etc.
- should the other init(8) signals for e.g. single user, etc. be
implemented? Currently, these are not implement as shutdown is
~90% of cases, and wanted to verify I'm taking the proper direction.
- mailbox signals aren't really documented in the manual at the
moment..

Comments / Questions / feedback welcome.

Thanks!

- Chris

Files

vkhalt.patch (6.84 KB) vkhalt.patch c.turner, 05/20/2007 09:10 PM
vkhalt-HEAD.patch (4.99 KB) vkhalt-HEAD.patch c.turner, 06/10/2007 11:46 PM
vkhalt-HEAD.patch (3.4 KB) vkhalt-HEAD.patch c.turner, 06/16/2007 11:25 PM
vkhalt-HEAD.patch (4.55 KB) vkhalt-HEAD.patch c.turner, 06/17/2007 04:26 PM
Actions

Also available in: Atom PDF