Bug #1415

ext3 unmount panic

Added by polachok over 5 years ago. Updated 9 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:VFS subsystem
Target version:3.8.0

Description

I have a linux ext3 partition here. When trying to mount it, it doesn't work
(Bad file descriptor). When trying to unmount, panic appears. I don't have
firewire or serial here, so got a screenshot.

P7030299.JPG (79.8 KB) polachok, 07/03/2009 08:31 PM

History

#2 Updated by dillon over 5 years ago

:Alexander Polakov <> added the comment:
:
:I have a possible fix here, please take a look:
:
:http://github.com/polachok/dragonflybsd/commit/d8b7a4caaa2724148e9593920797=
:7a0730c349b2
:
:----------
:status: unread -> chatting

That looks reasonable. Can you verify that it still works with ext2?
Then I think we can commit it.

-Matt
Matthew Dillon
<>

#3 Updated by polachok over 5 years ago

>That looks reasonable. Can you verify that it still works with ext2?
>Then I think we can commit it.

Still works with a 9 years old ext2 from a random linux floppy distribution I
just downloaded.

#4 Updated by dillon over 5 years ago

:>That looks reasonable. Can you verify that it still works with ext2?
:>Then I think we can commit it.
:
:Still works with a 9 years old ext2 from a random linux floppy distribution=
: I
:just downloaded.

Excellent. Ok, I cherry-picked it from your github, with one
whitespace complaint fix by git.

GIT is so nice. Just being able to pull directly from other repos as a
matter of expectation makes it worth its weight in gold.

What about ce2c38dd9eaa1cb098507b936f39fca5476b0435 in your repo?
Would you like that integrated into the main tree too?

-Matt
Matthew Dillon
<>

#5 Updated by polachok over 5 years ago

>What about ce2c38dd9eaa1cb098507b936f39fca5476b0435 in your repo?
>Would you like that integrated into the main tree too?

Not really yet. It needs strcasecmp() and strsep() which should probably belong
to libkern (like it's done in FreeBSD). I put them into compat.c, but it doesn't
look like a good solution for me.
And we should probably wait for 8.0 to port shining new features described in
http://people.freebsd.org/~ariff/SOUND_4.TXT.html. It fixes some suspend/resume
problems on my eee, but ACPI in the main tree is not ready for suspend anyway.

#6 Updated by tuxillo 9 months ago

  • Description updated (diff)
  • Category set to VFS subsystem
  • Status changed from New to Closed
  • Assignee deleted (0)
  • Target version set to 3.8.0

Hi,

In our tree:

commit 469327903134dbe076c692e1824d870012bcb5e5
Author: Matthew Dillon <>
Date: Tue Jul 21 12:39:03 2009 -0700

EXT2FS: support variable inode size.

Obtained-from: FreeBSD
Cherry-picked-from: http://github.com/polachok/dragonflybsd/commit/d8b7a4caaa2724148e95939207977a0730c349b2
Submitted-by: Alexander Polakov

The github repo is no longer available and the other commit matt referred seemed to not be ready so I'm closing this.

Also available in: Atom PDF