Bug #1482

ext2fs updates from ffs

Added by pfgshield-freebsd over 4 years ago. Updated about 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-

Description

Hello;

The attached patch is meant for FreeBSD but the affected code doesn't
seem to have changed in DragonFly (other that relocation that is). It
may require some tweaking to apply correctly though.

It basically adopts some changes that we made with the Lite2 commit and
a afterwards in ffs. A one liner fix from Bruce Evans is also included.
This should also help future adoption of the BSD-licensed ext2fs port
that has been progressing as part of FreeBSD's Google Summer of Code.

enjoy,

Pedro.

patch-ext2fs (4.2 KB) pfgshield-freebsd, 09/01/2009 06:57 PM

patch-ext2fs (9.62 KB) pfgshield-freebsd, 09/11/2009 03:26 PM

History

#1 Updated by pfgshield-freebsd over 4 years ago

Hi again;

Here is an updated patch.

#2 Updated by dillon over 4 years ago

:Hi again;
:
:Here is an updated patch.

Thanks Pedro. I will apply the brelse fixes, the i_next_alloc_block
fix, and a few others to DragonFly. We will have to forego the
application of the ASYNC enhancements and most of the syntax changes
(though I'll definitely keep the 'error =' syntax adjustments),
mainly because we are too close to the release to test them and I
don't want to create any accidental bugs. ext2fs support is really
just there for accessibility, we don't expect people to use ext2fs for
a main filesystem in DragonFly.

-Matt

#3 Updated by pfgshield-freebsd over 4 years ago

Matthew Dillon wrote:
> :Hi again;
> :
> :Here is an updated patch.
>
> Thanks Pedro. I will apply the brelse fixes, the i_next_alloc_block
> fix, and a few others to DragonFly. We will have to forego the
> application of the ASYNC enhancements and most of the syntax changes
> (though I'll definitely keep the 'error =' syntax adjustments),
> mainly because we are too close to the release to test them and I
> don't want to create any accidental bugs. ext2fs support is really
> just there for accessibility, we don't expect people to use ext2fs for
> a main filesystem in DragonFly.
>
> -Matt

Hi Matt;

The ASYNC enhancements are actually harmless but I agree with the idea
of minimizing unnecessary risks before a release.

Ext2fs is rather uninteresting for default use but with Aditya's port of
NetBSD's allocation code, the new BSD-licensed ext2fs is a copy cat of
UFS1. This means we could start using some enhancements from FFS
(softupdates sounds crazy but is doable) and we could check some of
linux's developments (preallocation, Htree) to see if they make sense in
UFS.

Not as fun as HAMMER, but nevertheless fun ;-).

Pedro.

#4 Updated by alexh about 4 years ago

Has this made it in yet? If not, do we want it in for after the release?

Cheers,
Alex Hornung

#5 Updated by pfgshield-freebsd about 4 years ago

Hello;

Alex Hornung (via DragonFly issue tracker) wrote:
> Alex Hornung <> added the comment:
>
> Has this made it in yet? If not, do we want it in for after the release?
>
> Cheers,
> Alex Hornung
>

Yes, Some parts were left out (async enhancements) but Matt Dillon
committed the critical parts.

BTW, the locking would require redoing but it would be nice to see the
BSD licensed ext2fs from FreeBSD merged someday.

Pedro.

#6 Updated by tuxillo about 1 year ago

  • Description updated (diff)
  • Status changed from New to Closed
  • Assignee deleted (0)

Hi,

Thanks for the patches!
I've added 'Bring BSD-licensed ext2fs from FreeBSD' to our Projects page.

Cheers,
Antonio Huete

Also available in: Atom PDF