Bug #1896

scandir select/filter not taking const struct dirent *

Added by alexh over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:swildner% Done:

0%

Category:-
Target version:-

Description

Our scandir(3) takes a functor int (*select)(struct dirent *) while Linux, NetBSD
and FreeBSD take int (*select)(const struct dirent *).

This would incindentally also fix compilation of devel/libcompizconfig.

Anyone opposed to changing it to const struct dirent * ?

Regards,
Alex

unnamed (827 Bytes) alexh, 11/04/2010 07:55 PM

History

#1 Updated by dillon over 3 years ago

:Our scandir(3) takes a functor int (*select)(struct dirent *) while Linux, NetBSD
:and FreeBSD take int (*select)(const struct dirent *).
:
:This would incindentally also fix compilation of devel/libcompizconfig.
:
:Anyone opposed to changing it to const struct dirent * ?
:
:Regards,
:Alex

Sounds good to me.

-Matt
Matthew Dillon
<>

#2 Updated by swildner over 3 years ago

grab

#3 Updated by alexh over 3 years ago

Thanks Sascha!
On 4 Nov 2010 19:49, "Sascha Wildner (via DragonFly issue tracker)" <
> wrote:
>
> Sascha Wildner <> added the comment:
>
> grab
>
> ----------
> assignedto: -> swildner
> nosy: +swildner
>
> _____________________________________________________
> DragonFly issue tracker <>
> <http://bugs.dragonflybsd.org/issue1896>
> _____________________________________________________

#4 Updated by swildner over 3 years ago

I've committed a fix. Since it includes more changes than just what was
proposed originally, could you try again and check if it actually fixed the
devel/libcompizconfig issue?

#5 Updated by alexh over 3 years ago

devel/libcompizconfig seems to compile perfectly now, thanks.

Closing, committed in edacbda68e2b4fcf6f29f472d4c2720d202639dc.

Also available in: Atom PDF