Submit #2607: [PATCH] Add proper const keywords to sysctl(3) parameters. - DragonFlyBSD - DragonFlyBSD bugtracker

Actions

Copy link

Submit #2607

closed

[PATCH] Add proper const keywords to sysctl(3) parameters.

Added by kAworu about 11 years ago. Updated about 11 years ago.

Status:

Closed

Priority:

Low

Assignee:

Category:

Target version:

Start date:

11/22/2013

Due date:

% Done:

Estimated time:

Description

This patch import several patches from FreeBSD, namely:
- r204170 which make use of const keywords where appropriate
- r240176 which avoid a segfault when the `name' argument is invalid
- r204172 & r244153 are cosmetics changes.

I did a build of world+kernel and install and it has running fine for several hours.
More tests and code reviews are welcome. In particular I am unsure of r240176 (how is `name' tested for "validity"?).

Files

0001-Add-proper-const-keywords-to-sysctl-3-parameters.patch (6.98 KB) 0001-Add-proper-const-keywords-to-sysctl-3-parameters.patch

kAworu, 11/22/2013 11:06 AM

Actions

Copy link

Updated by kAworu about 11 years ago

kAworu wrote:

[...]
In particular I am unsure of r240176 (how is `name' tested for "validity"?).

OK I think I got it: that's because sys___sysctl() begin by copyin(9) `name' which will return EFAULT if a bad address is encoutered.

Actions

Copy link

Updated by kAworu about 11 years ago

As additional tests I've run `sysctl -a' and `sysctl -ad' with and without the patch. As expected, The `sysctl -ad' output was the same and `sysctl -a' revealed expected diff for some values (load average, vm stats vfs cache etc.).

Actions

Copy link