Project

General

Profile

Submit #2791

Float exception with vi

Added by dclink about 2 years ago. Updated almost 2 years ago.

Status:
In Progress
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
02/21/2015
Due date:
% Done:

0%


Description

How to reproduce :
- set COLUMNS or LINES env var with unexpected values.
Proposed fix :
- Fallback to default values in those cases.

patch-nvi.txt View (965 Bytes) dclink, 02/21/2015 10:29 AM

History

#1 Updated by dragonflybsd1 about 2 years ago

looks reasonable to me.

#2 Updated by vadaszi almost 2 years ago

  • Status changed from New to In Progress

It would be nice, if the default values for row and col wouldn't be duplicated by this change.
The errno variable should be explicitly set to 0 before calling strtol, when you want to check errno != 0 afterwards.
Also we it would make sense to fallback to default values when negative values are given for COLUMNS or LINES.

Note that there are a few other places which call getenv("LINES") or getenv("COLUMNS") throughout nvi, which .
As an alternative instead of silently falling back to default values, it might make sense to abort vi with an error message, if we would crash anyway afterwards.

Note that there is an active upstream project for DragonFly's vi: <https://github.com/lichray/nvi2&gt;, which might be a better place to submit and discuss this change.

Also available in: Atom PDF