Project

General

Profile

Bug #2847

rtadvd: improper padding of DNSSL option

Added by cmusser about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Networking
Target version:
Start date:
10/19/2015
Due date:
% Done:

0%


Description

The rtadvd program, recently refreshed from FreeBSD, mishandles DNSSL
options, which need to be padded to an eight byte boundary. The code
correctly calculates the padding length, then fails to increment the
pointer used to write the packet data by this amount. As a result, all
subsequent option data gets written into the wrong place, making the
rest of the packet junk.

The attached patch (for the master branch) fixes this.

rtadvd_config.c.diff View (795 Bytes) cmusser, 10/19/2015 04:09 PM

History

#1 Updated by sepherosa about 2 years ago

Patch pushed.

On Tue, Oct 20, 2015 at 7:10 AM,
<> wrote:
> Issue #2847 has been reported by cmusser.
>
> ----------------------------------------
> Bug #2847: rtadvd: improper padding of DNSSL option
> http://bugs.dragonflybsd.org/issues/2847
>
> * Author: cmusser
> * Status: New
> * Priority: Normal
> * Assignee:
> * Category: Networking
> * Target version: 4.2.x
> ----------------------------------------
> The rtadvd program, recently refreshed from FreeBSD, mishandles DNSSL
> options, which need to be padded to an eight byte boundary. The code
> correctly calculates the padding length, then fails to increment the
> pointer used to write the packet data by this amount. As a result, all
> subsequent option data gets written into the wrong place, making the
> rest of the packet junk.
>
> The attached patch (for the master branch) fixes this.
>
> ---Files--------------------------------
> rtadvd_config.c.diff (795 Bytes)
>
>
> --
> You have received this notification because you have either subscribed to it, or are involved in it.
> To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account

--
Tomorrow Will Never Die

#2 Updated by swildner over 1 year ago

Fixed according to sephe. Closing.

#3 Updated by swildner over 1 year ago

  • Status changed from New to Closed

Also available in: Atom PDF