Project

General

Profile

Actions

Bug #2847

closed

rtadvd: improper padding of DNSSL option

Added by cmusser over 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Networking
Target version:
Start date:
10/19/2015
Due date:
% Done:

0%

Estimated time:

Description

The rtadvd program, recently refreshed from FreeBSD, mishandles DNSSL
options, which need to be padded to an eight byte boundary. The code
correctly calculates the padding length, then fails to increment the
pointer used to write the packet data by this amount. As a result, all
subsequent option data gets written into the wrong place, making the
rest of the packet junk.

The attached patch (for the master branch) fixes this.


Files

rtadvd_config.c.diff (795 Bytes) rtadvd_config.c.diff cmusser, 10/19/2015 04:09 PM
Actions #1

Updated by sepherosa over 8 years ago

Patch pushed.

On Tue, Oct 20, 2015 at 7:10 AM,
<> wrote:

Issue #2847 has been reported by cmusser.

----------------------------------------
Bug #2847: rtadvd: improper padding of DNSSL option
http://bugs.dragonflybsd.org/issues/2847

  • Author: cmusser
  • Status: New
  • Priority: Normal
  • Assignee:
  • Category: Networking
  • Target version: 4.2.x
    ----------------------------------------
    The rtadvd program, recently refreshed from FreeBSD, mishandles DNSSL
    options, which need to be padded to an eight byte boundary. The code
    correctly calculates the padding length, then fails to increment the
    pointer used to write the packet data by this amount. As a result, all
    subsequent option data gets written into the wrong place, making the
    rest of the packet junk.

The attached patch (for the master branch) fixes this.

---Files--------------------------------
rtadvd_config.c.diff (795 Bytes)

--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account

--
Tomorrow Will Never Die

Actions #2

Updated by swildner almost 8 years ago

Fixed according to sephe. Closing.

Actions #3

Updated by swildner almost 8 years ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF