Project

General

Profile

Submit #2854

Support for place independent executables

Added by shamaz over 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Kernel
Target version:
-
Start date:
11/25/2015
Due date:
% Done:

0%

Estimated time:

Description

Hello. If you launch a PIE, the loader will map it in memory to a fixed
position (ET_DYN_LOAD_ADDR). This patch changes this behaviour and makes
the loader respect vm.randomize_map sysctl.

pie.patch (1.98 KB) pie.patch shamaz, 11/25/2015 11:03 AM
pie2.patch (2.18 KB) pie2.patch shamaz, 12/04/2015 06:50 AM
pie3.patch (2.11 KB) pie3.patch shamaz, 12/06/2015 01:19 AM
pie_sysctl.patch (4.05 KB) pie_sysctl.patch shamaz, 12/25/2015 07:57 AM

History

#1 Updated by shamaz over 3 years ago

  • Tracker changed from Bug to Submit
  • Category set to Kernel

#2 Updated by marino over 3 years ago

wouldn't you have to remove the comment "
* Honour the base load address from the dso if it is
* non-zero for some reason."

as well?

can you explain why ET_DYN_LOAD_ADDR existed before and why "1" is the correct value for
et_dyn_add ?

#3 Updated by shamaz over 3 years ago

I send a new patch with a bit more explanation in comments.

> can you explain why ET_DYN_LOAD_ADDR existed before

I don't know. It's just a hardcoded virtual address to be used instead of p_vaddr field of the first PT_LOAD program header, if the latter is 0. I think, it could be, say, 0x400000 as well as 0x1021000. The old code was brought there from FreeBSD which does not have ASLR, so hardcoded non-random value can be OK for it.

#4 Updated by marino over 3 years ago

okay, i didn't see the last hunk before. I couldn't figure out what was special about the value of "1".

The comments are going way past 80 columns though, so they need to be wrapped earlier.

I'll ask dillon if the last hunk is good. The rest of the patch looks okay to me.

#5 Updated by shamaz over 3 years ago

> The comments are going way past 80 columns though, so they need to be wrapped earlier.

Fixed in the new patch. I hope everything is OK now.

#6 Updated by dillon over 3 years ago

The only issue I see is that we want the previous behavior of using ET_DYN_LOAD_ADDR to remain if randomization is turned off and it doesn't appear to be.

-Matt

#7 Updated by shamaz over 3 years ago

What is so special about ET_DYN_LOAD_ADDR? Is it really important to keep backward compatibility when vm.randomize_mmap=0? PIE code doesn't care where it is loaded in memory, no matter if it's randomized or not. Treat it like a shared library. Also it will not cause any trouble to userland programs, because world and ports are compiled as normal executables, not as PIEs. Currently, vm.randomize_mmap is only checked in vm_map_hint(), do you really want to check it somewhere else, making the code more complex and harder to understand? If you want, I can try to build some apps from DPorts with -pie flag and check if they are working (already tried flac decoder), just name it. If you want to keep ET_DYN_LOAD_ADDR, I'll just give up ) It is simpy a macro from FreeBSD which does not support ASLR at all.

#8 Updated by dillon over 3 years ago

I'd rather make changes like this slowly. Its enough for now to change it to support the randomization, but I don't want to change the defaults at the same time. The dynamic load address is basically in low (virtual) memory, whereas the hint I think is going to put it somewhere above the 32GB mark in VM. I'd rather not make that change (and, in fact, I don't really like the idea of putting the executable that high anyway)

-Matt

#9 Updated by marino over 3 years ago

shamaz, did you drop this?

#10 Updated by shamaz over 3 years ago

If you wish to save the old behaviour, you can look at this new patch I am sending. It adds a new sysctl kern.elf64.pie_base_mmap (you may want to change both name and description, I cannot think out any better). If it is set to 1, vm_map_hint() is used, ET_DYN_LOAD_ADDR otherwise.

#11 Updated by shamaz over 3 years ago

It also replaces 8 or more spaces with tab(s) in two or three places.

#12 Updated by marino over 3 years ago

sorry, i've been busy with other stuff, I'll try to flag dillon's attention to this the next time I see him. I don't know if he was asking for new sysctls though.

#13 Updated by dillon almost 3 years ago

  • Status changed from New to Closed

Committed to master!

-Matt

Also available in: Atom PDF