Bug #73

outb|inb warnings patch

Added by slynko over 7 years ago. Updated 2 months ago.

Status:Closed Start date:
Priority:Low Due date:
Assignee:- % Done:

0%
Category:-
Target version:-

Description

Hi,

this patch fix warnings produced by macros like outb (see the comment to
outb macro in sys/i386/include/cpufunc.h)

clock.outb.diff (605 Bytes) slynko, 01/18/2006 05:59 pm

spic.outb.diff (566 Bytes) slynko, 01/18/2006 05:59 pm

Related todos

History

#1
Updated by joerg over 7 years ago

On Wed, Jan 18, 2006 at 08:52:27PM +0300, Alexey Slynko wrote:
> Hi,
>
> this patch fix warnings produced by macros like outb (see the comment to
> outb macro in sys/i386/include/cpufunc.h)

Please don't do this, this warnings are a good reminder that the code is
archaic and MUST be converted to newbus. Beside that is this fix
incorrect since ports are 16bit integers, aka shorts. The choosen type
is perfectly valid.

Joerg

#2
Updated by qhwt+dfly almost 7 years ago

On Wed, Jan 18, 2006 at 08:55:14PM +0100, joerg@britannica.bec.de wrote:
> Please don't do this, this warnings are a good reminder that the code is
> archaic and MUST be converted to newbus.

So, is anyone working on converting them to newbus? :)

#3
Updated by swildner 9 months ago

  • File deleted (if_sr.outb.diff)

#4
Updated by swildner 9 months ago

  • File deleted (if_rdp.outb.diff)

#5
Updated by swildner 9 months ago

  • File deleted (if_ie.outb.diff)

#6
Updated by swildner 9 months ago

  • File deleted (cronyx.outb.diff)

#7
Updated by tuxillo 3 months ago

  • Description updated (diff)
  • Status changed from New to Feedback
  • Assignee deleted (0)

Hi,

Does somebody have more information on this 'newbus conversion' stuff?
If so, either update this ticket or add it to the 'Projects page' and close this ticket.

Best regards,
Antonio Huete

#8
Updated by swildner 2 months ago

  • Status changed from Feedback to Closed

There are no warnings anymore in the files affected by the two leftover patches (the rest were already removed some months ago). I guess this is due to compiler differences (GCC 4.4 and 4.7 both seem to get along fine with the current code).

Also available in: Atom PDF