Bug #81

possible readline license violation

Added by joerg over 8 years ago. Updated over 7 years ago.

Status:ClosedStart date:
Priority:HighDue date:
Assignee:memmerto% Done:

0%

Category:-
Target version:-

Description

vinum and two Kerberos utilities currently link against readline. At least vinum
contains an advertisement clause, which renders its invalid to link against the
GPLed readline.

readline-krb5.txt Magnifier (588 Bytes) memmerto, 01/19/2007 03:23 AM

vinum.licence.patch Magnifier (3.84 KB) memmerto, 01/20/2007 12:17 AM

History

#1 Updated by memmerto about 8 years ago

I'll take a look at seeing if we can use the BSD-licensed libedit instead.

#2 Updated by pavalos almost 8 years ago

What's the status of this?

#3 Updated by joerg almost 8 years ago

Don't know if anything changed.

Joerg

#4 Updated by memmerto almost 8 years ago

Put this on my list of things to look at.

#5 Updated by memmerto almost 8 years ago

Investigation reveals that although the two KRB5 utilities (kadmin, ktutil)
link with -lreadline, they don't actually use the readline facilities.

The following patch removes -lreadline, and is buildworld clean.

#6 Updated by justin almost 8 years ago

Does vinum link but not use, too? And/Or: does the FreeBSD version of vinum
have the same issue?

#7 Updated by memmerto almost 8 years ago

Our vinum links with *and* uses readline, so more work is required to fix that.

FreeBSD-6 uses a GEOM-based vinum, which links with and uses readline.
However, it appears to be considerably rewritten from the non-GEOM vinum, and
uses the new BSD licence (no adv clause) so they are fine linking with the
GPL'd readline.

#8 Updated by justin almost 8 years ago

Does the advertising clause still apply to the old vinum code? There were
some licenses where that hadn't been cleaned out in FreeBSD until
recently. This may be a question for Greg Lehey.

#9 Updated by memmerto almost 8 years ago

We can remove the advertising clause from the vinum code, as per this email
from Greg. Patch attached.

On Friday, 19 January 2007 at 15:23:36 -0500, Matt Emmerton wrote:
> Greg,
>
> I'm working on DragonFlyBSD, which branched from FreeBSD-4.x. As such, it
> has an "old" version of vinum which uses a BSD licence which includes an
> advertising clause. (Interestingly, not requiring Berkeley to be mentioned,
> but some other organization.)
>
> I know that vinum has undergone a GEOM-ification in newer FreeBSD releases,
> and it appears that all the new code in FreeBSD does not have any advertising
> clauses. However, this is not useful to us since we don't have GEOM.

Understood. I've already sent a message to the FreeBSD people saying
that they can remove the advertising clause; of course you may do so
as well.

Greg

#10 Updated by dillon almost 8 years ago

:Matt Emmerton <> added the comment:
:
:Investigation reveals that although the two KRB5 utilities (kadmin, ktutil)=20
:link with -lreadline, they don't actually use the readline facilities.
:
:The following patch removes -lreadline, and is buildworld clean.

I applied the patch manually. I couldn't apply it automatically
even with patch -p N because it does not seem to be using the
proper relative paths :-)

-Matt
Matthew Dillon
<>

:Index: kerberos5/usr.sbin/ktutil/Makefile
:===================================================================
:RCS file: /home/dcvs/src/kerberos5/usr.sbin/ktutil/Makefile,v
:retrieving revision 1.4
:diff -r1.4 Makefile
:23c23
:< -lreadline -lncurses
:---
:> -lncurses
:Index: kerberos5/usr.bin/kadmin/Makefile
:===================================================================
:RCS file: /home/dcvs/src/kerberos5/usr.bin/kadmin/Makefile,v
:retrieving revision 1.1
:diff -r1.1 Makefile
:31c31
:< -lreadline -lncurses ${LDAPLDADD}
:---
:> -lncurses ${LDAPLDADD}

#11 Updated by dillon almost 8 years ago

:Matt Emmerton <> added the comment:
:
:We can remove the advertising clause from the vinum code, as per this email=20
:from Greg. Patch attached.

Committed!

-Matt

#12 Updated by swildner almost 8 years ago

Did you actually check this with -DWANT_KERBEROS (which fails after the
patch was committed).

Sascha

#13 Updated by memmerto almost 8 years ago

I have confirmed that the patch breaks world when WANT_KERBEROS is set.
It appears that although kadmin/ktutil don't use readline themselves, libsl
(which they link with) is the real user of readline.

I note that it appears that kadmin and kadmin are the only things to link with
libsl, and that the libsl sources have #ifdef HAVE_READLINE wrappers around all
readline-related code.

I see two options:
1) flip the HAVE_READLINE bit so that we don't need to link with readline, but
also lose readline support (line editing and history) in the process
2) update libsl to use libedit instead of readline.

#14 Updated by corecode almost 8 years ago

+1 for using libedit, but possibly after the release.

cheers
simon

#15 Updated by dillon almost 8 years ago

:I have confirmed that the patch breaks world when WANT_KERBEROS is set.
:It appears that although kadmin/ktutil don't use readline themselves, libsl
:(which they link with) is the real user of readline.
:
:I note that it appears that kadmin and kadmin are the only things to link with
:libsl, and that the libsl sources have #ifdef HAVE_READLINE wrappers around all
:readline-related code.
:
:I see two options:
:1) flip the HAVE_READLINE bit so that we don't need to link with readline, but
:also lose readline support (line editing and history) in the process
:2) update libsl to use libedit instead of readline.

Just flip HAVE_READLINE for now.

-Matt
Matthew Dillon
<>

#16 Updated by memmerto over 7 years ago

Looks like swilder committed a fix for this yesterday (undefining
HAVE_READLINE). Closing.

Also available in: Atom PDF