Project

General

Profile

Actions

Bug #240

closed

Patch line limit removal

Added by joerg over 18 years ago. Updated about 15 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hi all,
http://leaf.dragonflybsd.org/~joerg/patch.diff
contains the last missing piece to remove unnecessary line limits in
patch(1). Please test or review, I'd like to have this in the tree soon
:-)

Joerg

Actions #1

Updated by dillon over 18 years ago

:Hi all,
:http://leaf.dragonflybsd.org/~joerg/patch.diff
:contains the last missing piece to remove unnecessary line limits in
:patch(1). Please test or review, I'd like to have this in the tree soon
::-)
:
:Joerg

This is kinda messy:
#define __STDC_LIMIT_MACROS
Is there any way to not use those extensions ?
-Matt
Matthew Dillon
<>
Actions #2

Updated by dillon over 18 years ago

:
:Hi all,
:http://leaf.dragonflybsd.org/~joerg/patch.diff
:contains the last missing piece to remove unnecessary line limits in
:patch(1). Please test or review, I'd like to have this in the tree soon
::-)
:
:Joerg

Also, full_fgets() can be cleaned up a bit.  Just add a local
resize_len variable instead of copying 'buf_len * 2' all over
the place, and also clean up the last bit to read something like
this:
ret = fgets(resize_buf + buf_len, resize_len - buf_len, fp);
buf = resize_buf;
buf_len = resize_len;
-Matt
Matthew Dillon
<>
Actions #3

Updated by joerg over 18 years ago

On Fri, Jul 14, 2006 at 10:29:06AM -0700, Matthew Dillon wrote:

:Hi all,
:http://leaf.dragonflybsd.org/~joerg/patch.diff
:contains the last missing piece to remove unnecessary line limits in
:patch(1). Please test or review, I'd like to have this in the tree soon
::-)
:
:Joerg

This is kinda messy:

#define __STDC_LIMIT_MACROS

Is there any way to not use those extensions ?

This is a standard macro and part of C99.

Joerg

Actions #4

Updated by dillon over 18 years ago

:On Fri, Jul 14, 2006 at 10:29:06AM 0700, Matthew Dillon wrote:
:>
:> :Hi all,
:> :http://leaf.dragonflybsd.org/~joerg/patch.diff
:> :contains the last missing piece to remove unnecessary line limits in
:> :patch(1). Please test or review, I'd like to have this in the tree soon
:> ::
)
:> :
:> :Joerg
:>
:> This is kinda messy:
:>
:> #define __STDC_LIMIT_MACROS
:>
:> Is there any way to not use those extensions ?
:
:This is a standard macro and part of C99.
:
:Joerg

I really dislike having to pre-define anything prior to doing
an #include. There are a few places where we have no choice,
but if something is going to be 'standard C' then I just do not
accept that it must require a pre-defined macro to operate properly.
I suppose if you really, really want to use the macro you can make
it a -D option in the compile line. That is, fix the Makefile rather
then put the #define in the source code.
-Matt
Matthew Dillon
<>
Actions #5

Updated by tuxillo about 15 years ago

The patch on leaf seems to be no longer available. Also there was a patch(1)
sync with OpenBSD after the creation date of the submitted patch.
How can I check if the line limit is still there?

Actions #6

Updated by corecode about 15 years ago

I think this can be closed. New patch uses mmap, AFAIR

Actions #7

Updated by ahuete.devel about 15 years ago

plan_a() function uses indeed mmap() and comments state "/* Try
keeping everything in memory. */"
Is that what you meant?

2009/8/26 Simon 'corecode' Schubert (via DragonFly issue tracker)
<>:

Simon 'corecode' Schubert <> added the comment:

I think this can be closed.  New patch uses mmap, AFAIR

_____________________________________________
DragonFly issue tracker <>
<http://bugs.dragonflybsd.org/issue240>
_____________________________________________

Actions

Also available in: Atom PDF